Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes from upstream #199

Merged
merged 4 commits into from
Dec 20, 2023
Merged

Changes from upstream #199

merged 4 commits into from
Dec 20, 2023

Conversation

pussuw
Copy link

@pussuw pussuw commented Dec 19, 2023

Summary

Impact

Testing

Move log2ceil from riscv_pmp to libc. Also, implement log2floor for
completeness.

These are the run-time alternative to the compile-time macros.
DMA directly to user (virtual) memory won't work, as the DMA engine(s)
don't do address translations, i.e. they require a physical address.

Using kernel heap is fine as it is mapped vaddr=paddr. Also, the USB DMA
engine does not have any alignment requirements.
The hack just opens the entire SoC memory unconditionally, which is not
a good idea.

Test features can be used ad-hoc, they don't need to be supported by the
build.
@pussuw pussuw requested review from jlaitine and eenurkka December 19, 2023 09:41
Copy link

@eenurkka eenurkka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@pussuw pussuw merged commit 082e76f into master Dec 20, 2023
6 of 8 checks passed
@pussuw pussuw deleted the changes_from_upstream branch December 20, 2023 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants